franklinblanco
/
yuzu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

path_util: Resolve `-Wpointer-bool-conversion` warning 

Clang (rightfully) warns that we are checking for the existence of
pointer to something just allocated on the stack, which is always true.

Instead, check whether GetModuleFileNameW failed.

Co-authored-by: Mai M <mathew1800@gmail.com>
This commit is contained in:
lat9nq 2022-05-26 18:49:18 -04:00
parent a9beb4746e
commit 0e5a6676c3
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/common/fs/path_util.cpp
View File

@ -232,9 +232,7 @@ void SetYuzuPath(YuzuPath yuzu_path, const fs::path& new_path) {
fs::path GetExeDirectory() { fs::path GetExeDirectory() {
wchar_t exe_path[MAX_PATH]; wchar_t exe_path[MAX_PATH];
GetModuleFileNameW(nullptr, exe_path, MAX_PATH); if (GetModuleFileNameW(nullptr, exe_path, MAX_PATH) == 0) {
if (!exe_path) {
LOG_ERROR(Common_Filesystem, LOG_ERROR(Common_Filesystem,
"Failed to get the path to the executable of the current process"); "Failed to get the path to the executable of the current process");
} }