franklinblanco
/
yuzu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

texture_cache/util: Fix src being used instead of dst within DeduceBlitImages 

This line can only ever be reached if src is null, so dereferencing it
here is a logic bug that slipped through.

Instead, we dereference dst instead which is guaranteed to be valid.
This commit is contained in:
Lioncash 2021-04-19 13:01:48 -04:00
parent 9e7713c150
commit 17b7f0389a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/video_core/texture_cache/util.cpp
View File

@ -1139,7 +1139,7 @@ void DeduceBlitImages(ImageInfo& dst_info, ImageInfo& src_info, const ImageBase*
dst_info.format = src->info.format; dst_info.format = src->info.format;
} }
if (!src && dst && GetFormatType(dst->info.format) != SurfaceType::ColorTexture) { if (!src && dst && GetFormatType(dst->info.format) != SurfaceType::ColorTexture) {
src_info.format = src->info.format; src_info.format = dst->info.format;
} }
} }