From 287a0f72a5474a5c8c8cdf2b15fb61532e11ec61 Mon Sep 17 00:00:00 2001 From: lat9nq <22451773+lat9nq@users.noreply.github.com> Date: Fri, 4 Jun 2021 05:12:14 -0400 Subject: [PATCH] decoders: Break instead of continue continue causes a memory leak in A Hat in Time. --- src/video_core/textures/decoders.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/video_core/textures/decoders.cpp b/src/video_core/textures/decoders.cpp index 1bccc09d9..f1f523ad1 100644 --- a/src/video_core/textures/decoders.cpp +++ b/src/video_core/textures/decoders.cpp @@ -66,9 +66,9 @@ void Swizzle(std::span output, std::span input, u32 bytes_per_pixe if (const auto offset = (TO_LINEAR ? unswizzled_offset : swizzled_offset); offset >= input.size()) { // TODO(Rodrigo): This is an out of bounds access that should never happen. To - // avoid crashing the emulator, continue. + // avoid crashing the emulator, break. ASSERT_MSG(false, "offset {} exceeds input size {}!", offset, input.size()); - continue; + break; } u8* const dst = &output[TO_LINEAR ? swizzled_offset : unswizzled_offset];