franklinblanco
/
yuzu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

yuzu/configure_input_player: Use std::size_t to represent the player index instead of u8 

Prevents compiler warnings related to truncation when invoking the
dialog. It's also extremely suspect to use a u8 value here instead of a
more general type to begin with.
This commit is contained in:
Lioncash 2018-11-27 05:17:11 -05:00
parent 0782d3971b
commit 2a22c1b27e
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/yuzu/configuration/configure_input_player.cpp
View File

@ -104,7 +104,7 @@ static QString AnalogToText(const Common::ParamPackage& param, const std::string
} }
}; };
ConfigureInputPlayer::ConfigureInputPlayer(QWidget* parent, u8 player_index, bool debug) ConfigureInputPlayer::ConfigureInputPlayer(QWidget* parent, std::size_t player_index, bool debug)
: QDialog(parent), ui(std::make_unique<Ui::ConfigureInputPlayer>()), player_index(player_index), : QDialog(parent), ui(std::make_unique<Ui::ConfigureInputPlayer>()), player_index(player_index),
debug(debug), timeout_timer(std::make_unique<QTimer>()), debug(debug), timeout_timer(std::make_unique<QTimer>()),
poll_timer(std::make_unique<QTimer>()) { poll_timer(std::make_unique<QTimer>()) {

4
src/yuzu/configuration/configure_input_player.h
View File

@ -30,7 +30,7 @@ class ConfigureInputPlayer : public QDialog {
Q_OBJECT Q_OBJECT
public: public:
explicit ConfigureInputPlayer(QWidget* parent, u8 player_index, bool debug = false); explicit ConfigureInputPlayer(QWidget* parent, std::size_t player_index, bool debug = false);
~ConfigureInputPlayer() override; ~ConfigureInputPlayer() override;
/// Save all button configurations to settings file /// Save all button configurations to settings file
@ -62,7 +62,7 @@ private:
std::unique_ptr<Ui::ConfigureInputPlayer> ui; std::unique_ptr<Ui::ConfigureInputPlayer> ui;
u8 player_index; std::size_t player_index;
bool debug; bool debug;
std::unique_ptr<QTimer> timeout_timer; std::unique_ptr<QTimer> timeout_timer;