franklinblanco
/
yuzu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

emu_window: Pass OnMinimalClientAreaChangeRequest argument by copy 

There's no performance improvement in passing an unsigned pair by
reference.
This commit is contained in:
ReinUsesLisp 2019-05-25 17:50:20 -03:00
parent 4b80dd23a4
commit 37eaf39b44
5 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/core/frontend/emu_window.h
View File

@ -169,8 +169,7 @@ private:
* For the request to be honored, EmuWindow implementations will usually reimplement this * For the request to be honored, EmuWindow implementations will usually reimplement this
* function. * function.
*/ */
virtual void OnMinimalClientAreaChangeRequest( virtual void OnMinimalClientAreaChangeRequest(std::pair<unsigned, unsigned>) {
const std::pair<unsigned, unsigned>& minimal_size) {
// By default, ignore this request and do nothing. // By default, ignore this request and do nothing.
} }

3
src/yuzu/bootmanager.cpp
View File

@ -440,8 +440,7 @@ void GRenderWindow::CaptureScreenshot(u16 res_scale, const QString& screenshot_p
layout); layout);
} }
void GRenderWindow::OnMinimalClientAreaChangeRequest( void GRenderWindow::OnMinimalClientAreaChangeRequest(std::pair<unsigned, unsigned> minimal_size) {
const std::pair<unsigned, unsigned>& minimal_size) {
setMinimumSize(minimal_size.first, minimal_size.second); setMinimumSize(minimal_size.first, minimal_size.second);
} }

3
src/yuzu/bootmanager.h
View File

@ -162,8 +162,7 @@ private:
void TouchUpdateEvent(const QTouchEvent* event); void TouchUpdateEvent(const QTouchEvent* event);
void TouchEndEvent(); void TouchEndEvent();
void OnMinimalClientAreaChangeRequest( void OnMinimalClientAreaChangeRequest(std::pair<unsigned, unsigned> minimal_size) override;
const std::pair<unsigned, unsigned>& minimal_size) override;
QWidget* container = nullptr; QWidget* container = nullptr;
GGLWidgetInternal* child = nullptr; GGLWidgetInternal* child = nullptr;

3
src/yuzu_cmd/emu_window/emu_window_sdl2.cpp
View File

@ -172,7 +172,6 @@ void EmuWindow_SDL2::PollEvents() {
} }
} }
void EmuWindow_SDL2::OnMinimalClientAreaChangeRequest( void EmuWindow_SDL2::OnMinimalClientAreaChangeRequest(std::pair<unsigned, unsigned> minimal_size) {
const std::pair<unsigned, unsigned>& minimal_size) {
SDL_SetWindowMinimumSize(render_window, minimal_size.first, minimal_size.second); SDL_SetWindowMinimumSize(render_window, minimal_size.first, minimal_size.second);
} }

3
src/yuzu_cmd/emu_window/emu_window_sdl2.h
View File

@ -50,8 +50,7 @@ protected:
void Fullscreen(); void Fullscreen();
/// Called when a configuration change affects the minimal size of the window /// Called when a configuration change affects the minimal size of the window
void OnMinimalClientAreaChangeRequest( void OnMinimalClientAreaChangeRequest(std::pair<unsigned, unsigned> minimal_size) override;
const std::pair<unsigned, unsigned>& minimal_size) override;
/// Is the window still open? /// Is the window still open?
bool is_open = true; bool is_open = true;