From 84b542c386063339c03069b8f4db8221200a27cd Mon Sep 17 00:00:00 2001 From: Subv Date: Sun, 12 Aug 2018 17:49:55 -0500 Subject: [PATCH] Kernel/Threads: Lock the HLE mutex when executing the wakeup callback. Another thread might be in the middle of a reschedule, thus altering the state of the schedulers. --- src/core/hle/kernel/thread.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/core/hle/kernel/thread.cpp b/src/core/hle/kernel/thread.cpp index e308b9c7b..5f87ff859 100644 --- a/src/core/hle/kernel/thread.cpp +++ b/src/core/hle/kernel/thread.cpp @@ -23,6 +23,7 @@ #include "core/hle/kernel/object.h" #include "core/hle/kernel/process.h" #include "core/hle/kernel/thread.h" +#include "core/hle/lock.h" #include "core/hle/result.h" #include "core/memory.h" @@ -104,6 +105,10 @@ void ExitCurrentThread() { */ static void ThreadWakeupCallback(u64 thread_handle, int cycles_late) { const auto proper_handle = static_cast(thread_handle); + + // Lock the global kernel mutex when we enter the kernel HLE. + std::lock_guard lock(HLE::g_hle_lock); + SharedPtr thread = wakeup_callback_handle_table.Get(proper_handle); if (thread == nullptr) { LOG_CRITICAL(Kernel, "Callback fired for invalid thread {:08X}", proper_handle);