Merge pull request #533 from mailwl/array-to-buffer

Common/string_util: add StringFromBuffer() function
This commit is contained in:
bunnei 2018-06-08 18:51:00 -04:00 committed by GitHub
commit 9949e4d508
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 15 additions and 22 deletions

View File

@ -64,6 +64,10 @@ std::string ArrayToString(const u8* data, size_t size, int line_len, bool spaces
return oss.str(); return oss.str();
} }
std::string StringFromBuffer(const std::vector<u8>& data) {
return std::string(data.begin(), std::find(data.begin(), data.end(), '\0'));
}
// Turns " hej " into "hej". Also handles tabs. // Turns " hej " into "hej". Also handles tabs.
std::string StripSpaces(const std::string& str) { std::string StripSpaces(const std::string& str) {
const size_t s = str.find_first_not_of(" \t\r\n"); const size_t s = str.find_first_not_of(" \t\r\n");

View File

@ -21,6 +21,8 @@ std::string ToUpper(std::string str);
std::string ArrayToString(const u8* data, size_t size, int line_len = 20, bool spaces = true); std::string ArrayToString(const u8* data, size_t size, int line_len = 20, bool spaces = true);
std::string StringFromBuffer(const std::vector<u8>& data);
std::string StripSpaces(const std::string& s); std::string StripSpaces(const std::string& s);
std::string StripQuotes(const std::string& s); std::string StripQuotes(const std::string& s);

View File

@ -4,6 +4,7 @@
#include <cinttypes> #include <cinttypes>
#include "common/logging/log.h" #include "common/logging/log.h"
#include "common/string_util.h"
#include "core/core.h" #include "core/core.h"
#include "core/file_sys/directory.h" #include "core/file_sys/directory.h"
#include "core/file_sys/filesystem.h" #include "core/file_sys/filesystem.h"
@ -258,9 +259,7 @@ public:
IPC::RequestParser rp{ctx}; IPC::RequestParser rp{ctx};
auto file_buffer = ctx.ReadBuffer(); auto file_buffer = ctx.ReadBuffer();
auto end = std::find(file_buffer.begin(), file_buffer.end(), '\0'); std::string name = Common::StringFromBuffer(file_buffer);
std::string name(file_buffer.begin(), end);
u64 mode = rp.Pop<u64>(); u64 mode = rp.Pop<u64>();
u32 size = rp.Pop<u32>(); u32 size = rp.Pop<u32>();
@ -275,9 +274,7 @@ public:
IPC::RequestParser rp{ctx}; IPC::RequestParser rp{ctx};
auto file_buffer = ctx.ReadBuffer(); auto file_buffer = ctx.ReadBuffer();
auto end = std::find(file_buffer.begin(), file_buffer.end(), '\0'); std::string name = Common::StringFromBuffer(file_buffer);
std::string name(file_buffer.begin(), end);
NGLOG_DEBUG(Service_FS, "called file {}", name); NGLOG_DEBUG(Service_FS, "called file {}", name);
@ -289,9 +286,7 @@ public:
IPC::RequestParser rp{ctx}; IPC::RequestParser rp{ctx};
auto file_buffer = ctx.ReadBuffer(); auto file_buffer = ctx.ReadBuffer();
auto end = std::find(file_buffer.begin(), file_buffer.end(), '\0'); std::string name = Common::StringFromBuffer(file_buffer);
std::string name(file_buffer.begin(), end);
NGLOG_DEBUG(Service_FS, "called directory {}", name); NGLOG_DEBUG(Service_FS, "called directory {}", name);
@ -305,13 +300,11 @@ public:
std::vector<u8> buffer; std::vector<u8> buffer;
buffer.resize(ctx.BufferDescriptorX()[0].Size()); buffer.resize(ctx.BufferDescriptorX()[0].Size());
Memory::ReadBlock(ctx.BufferDescriptorX()[0].Address(), buffer.data(), buffer.size()); Memory::ReadBlock(ctx.BufferDescriptorX()[0].Address(), buffer.data(), buffer.size());
auto end = std::find(buffer.begin(), buffer.end(), '\0'); std::string src_name = Common::StringFromBuffer(buffer);
std::string src_name(buffer.begin(), end);
buffer.resize(ctx.BufferDescriptorX()[1].Size()); buffer.resize(ctx.BufferDescriptorX()[1].Size());
Memory::ReadBlock(ctx.BufferDescriptorX()[1].Address(), buffer.data(), buffer.size()); Memory::ReadBlock(ctx.BufferDescriptorX()[1].Address(), buffer.data(), buffer.size());
end = std::find(buffer.begin(), buffer.end(), '\0'); std::string dst_name = Common::StringFromBuffer(buffer);
std::string dst_name(buffer.begin(), end);
NGLOG_DEBUG(Service_FS, "called file '{}' to file '{}'", src_name, dst_name); NGLOG_DEBUG(Service_FS, "called file '{}' to file '{}'", src_name, dst_name);
@ -323,9 +316,7 @@ public:
IPC::RequestParser rp{ctx}; IPC::RequestParser rp{ctx};
auto file_buffer = ctx.ReadBuffer(); auto file_buffer = ctx.ReadBuffer();
auto end = std::find(file_buffer.begin(), file_buffer.end(), '\0'); std::string name = Common::StringFromBuffer(file_buffer);
std::string name(file_buffer.begin(), end);
auto mode = static_cast<FileSys::Mode>(rp.Pop<u32>()); auto mode = static_cast<FileSys::Mode>(rp.Pop<u32>());
@ -349,9 +340,7 @@ public:
IPC::RequestParser rp{ctx}; IPC::RequestParser rp{ctx};
auto file_buffer = ctx.ReadBuffer(); auto file_buffer = ctx.ReadBuffer();
auto end = std::find(file_buffer.begin(), file_buffer.end(), '\0'); std::string name = Common::StringFromBuffer(file_buffer);
std::string name(file_buffer.begin(), end);
// TODO(Subv): Implement this filter. // TODO(Subv): Implement this filter.
u32 filter_flags = rp.Pop<u32>(); u32 filter_flags = rp.Pop<u32>();
@ -376,9 +365,7 @@ public:
IPC::RequestParser rp{ctx}; IPC::RequestParser rp{ctx};
auto file_buffer = ctx.ReadBuffer(); auto file_buffer = ctx.ReadBuffer();
auto end = std::find(file_buffer.begin(), file_buffer.end(), '\0'); std::string name = Common::StringFromBuffer(file_buffer);
std::string name(file_buffer.begin(), end);
NGLOG_DEBUG(Service_FS, "called file {}", name); NGLOG_DEBUG(Service_FS, "called file {}", name);