franklinblanco
/
yuzu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vp9: Avoid memcpy with null pointers 

Avoid sending null pointer to memcpy as reported by Undefined Behaviour
Sanitizer. Replaces the std::memcpy calls in SpliceVectors with
std::copy calls. Opting to replace all the memcpy's with copy's.

Co-authored-by: LC <mathew1800@gmail.com>
This commit is contained in:
lat9nq 2021-04-04 18:41:41 -04:00
parent 69b2dbdffd
commit a60653dcd3
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/video_core/command_classes/codecs/vp9.cpp
View File

@ -2,8 +2,9 @@
// Licensed under GPLv2 or any later version // Licensed under GPLv2 or any later version
// Refer to the license.txt file included. // Refer to the license.txt file included.
#include <cstring> // for std::memcpy #include <algorithm> // for std::copy
#include <numeric> #include <numeric>
#include "common/assert.h"
#include "video_core/command_classes/codecs/vp9.h" #include "video_core/command_classes/codecs/vp9.h"
#include "video_core/gpu.h" #include "video_core/gpu.h"
#include "video_core/memory_manager.h" #include "video_core/memory_manager.h"
@ -362,7 +363,8 @@ Vp9PictureInfo VP9::GetVp9PictureInfo(const NvdecCommon::NvdecRegisters& state)
// surface_luma_offset[0:3] contains the address of the reference frame offsets in the following // surface_luma_offset[0:3] contains the address of the reference frame offsets in the following
// order: last, golden, altref, current. It may be worthwhile to track the updates done here // order: last, golden, altref, current. It may be worthwhile to track the updates done here
// to avoid buffering frame data needed for reference frame updating in the header composition. // to avoid buffering frame data needed for reference frame updating in the header composition.
std::memcpy(vp9_info.frame_offsets.data(), state.surface_luma_offset.data(), 4 * sizeof(u64)); std::copy(state.surface_luma_offset.begin(), state.surface_luma_offset.begin() + 4,
vp9_info.frame_offsets.begin());
return vp9_info; return vp9_info;
} }
@ -821,11 +823,11 @@ const std::vector<u8>& VP9::ComposeFrameHeader(const NvdecCommon::NvdecRegisters
// Write headers and frame to buffer // Write headers and frame to buffer
frame.resize(uncompressed_header.size() + compressed_header.size() + bitstream.size()); frame.resize(uncompressed_header.size() + compressed_header.size() + bitstream.size());
std::memcpy(frame.data(), uncompressed_header.data(), uncompressed_header.size()); std::copy(uncompressed_header.begin(), uncompressed_header.end(), frame.begin());
std::memcpy(frame.data() + uncompressed_header.size(), compressed_header.data(), std::copy(compressed_header.begin(), compressed_header.end(),
compressed_header.size()); frame.begin() + uncompressed_header.size());
std::memcpy(frame.data() + uncompressed_header.size() + compressed_header.size(), std::copy(bitstream.begin(), bitstream.end(),
bitstream.data(), bitstream.size()); frame.begin() + uncompressed_header.size() + compressed_header.size());
// keep track of frame number // keep track of frame number
current_frame_number++; current_frame_number++;