franklinblanco/yuzu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

applets/swkbd: Make use of QueuedConnection in returnPressed signal

Browse Source 
Some users have reported rare crashes when pressing the Enter key on the keyboard to confirm input in the normal software keyboard, particularly in Super Smash Bros. Ultimate while entering the name of a ruleset or controller layout.

It is suspected that the QLineEdit::returnPressed signal is causing a race condition as confirming input through other means does not produce the crash. Since Qt::QueuedConnection posts an event to the event queue of the callee's thread instead of executing it directly on the caller's thread, this eliminates any potential race conditions from occurring in this scenario.
This commit is contained in:
Morph 2021-05-18 22:21:46 -04:00
parent 5068279f23
commit ecacb002be
1 changed files with 3 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/yuzu/applets/software_keyboard.cpp
View File

@ -720,21 +720,9 @@ void QtSoftwareKeyboardDialog::SetTextDrawType() {
ui->line_edit_osk->setFocus(); ui->line_edit_osk->setFocus();
}); });
connect(ui->line_edit_osk, &QLineEdit::returnPressed, [this] { connect(
switch (bottom_osk_index) { ui->line_edit_osk, &QLineEdit::returnPressed, this,
case BottomOSKIndex::LowerCase: [this] { TranslateButtonPress(HIDButton::Plus); }, Qt::QueuedConnection);
ui->button_ok->click();
break;
case BottomOSKIndex::UpperCase:
ui->button_ok_shift->click();
break;
case BottomOSKIndex::NumberPad:
ui->button_ok_num->click();
break;
default:
break;
}
});
ui->line_edit_osk->setPlaceholderText( ui->line_edit_osk->setPlaceholderText(
QString::fromStdU16String(initialize_parameters.guide_text)); QString::fromStdU16String(initialize_parameters.guide_text));