f3ac088345
sdl_impl: Prevent type truncation in BuildAnalogParamPackageForButton() default arguments
...
We need to add the 'f' suffix to make the right hand side a float and
not a double.
2020-08-28 21:08:08 -04:00
2e2dde2f95
sdl_impl: Simplify make_tuple call
...
The purpose of make_tuple is that you don't need to explicitly type out
the types of the things that comprise said tuple.
Given this just returns default values, we can simplify this a bit.
2020-08-28 21:04:18 -04:00
2680526e6b
sdl_impl: Mark FromEvent() as a const member function
...
This doesn't modify internal member state, so it can be marked as const.
2020-08-28 20:58:49 -04:00
57d9ef5a89
Merge pull request #4600 from lioncash/prototype
...
input_common/main: Remove unimplemented prototype
2020-08-28 20:10:33 -04:00
98f5d8a713
input_common/main: Remove unnecessary headers
2020-08-28 19:23:19 -04:00
4b9b203c09
input_common/main: Remove unimplemented prototype
...
I forgot to remove this in the rebase when removing most of the global
variables within the input common codebase.
2020-08-28 19:11:17 -04:00
fe90c4fd7b
vk_device: Blacklist AMD proprietary from VK_EXT_extended_dynamic_state
...
Vertex binding's <stride> is bugged on AMD's proprietary drivers when
using VK_EXT_extended_dynamic_state. Blacklist it for now while we
investigate how to report this issue to AMD.
2020-08-28 19:14:57 -03:00
45b73ba840
Merge pull request #4544 from lioncash/input-sub
...
input_common: Eliminate most global state
2020-08-28 09:57:50 -04:00
40320a1d84
Merge pull request #4586 from yuzu-emu/tsan-cpu-interrupt
...
cpu_interrupt_handler: Make is_interrupted an atomic
2020-08-28 09:21:47 -04:00
1be18dc110
Fix orientation errors and improve drift correction
2020-08-27 17:19:21 -05:00
e6fc3b5662
Address comments
2020-08-27 17:19:21 -05:00
2d207ec609
Implement a basic class for motion devices
2020-08-27 17:19:21 -05:00
9e1b0af259
input_common: Eliminate most global state
...
Abstracts most of the input mechanisms under an InputSubsystem class
that is managed by the frontends, eliminating any static constructors
and destructors. This gets rid of global accessor functions and also
allows the frontends to have a more fine-grained control over the
lifecycle of the input subsystem.
This also makes it explicit which interfaces rely on the input subsystem
instead of making it opaque in the interface functions. All that remains
to migrate over is the factories, which can be done in a separate
change.
2020-08-27 16:11:17 -04:00
3db9a25977
Merge pull request #4530 from Morph1984/mjolnir-p1
...
Project Mjölnir: Part 1 - Input Rewrite
2020-08-27 14:58:44 -04:00
3f7b0e0772
Merge pull request #4577 from lioncash/asserts
...
common/assert: Make use of C++ attribute syntax
2020-08-27 11:09:02 -04:00
9864da7d43
Merge pull request #4524 from lioncash/memory-log
...
shader/memory: Amend UNIMPLEMENTED_IF_MSG without a message
2020-08-27 00:16:10 -04:00
1bb8c27a70
Merge pull request #4569 from ReinUsesLisp/glsl-cmake
...
video_core/host_shaders: Add CMake integration for string shaders
2020-08-26 22:57:39 -04:00
8ffc491546
input_common/main: Add "/Mouse" to the display name
2020-08-26 22:41:51 -04:00
1e2a92918b
Merge pull request #4555 from ReinUsesLisp/fix-primitive-topology
...
vk_state_tracker: Fix primitive topology
2020-08-26 22:19:52 -04:00
7b50c48df7
memory_manager: Make use of [[nodiscard]] in the interface
2020-08-26 20:15:03 -04:00
d12d59f62a
memory_manager: Make operator+ const qualified
...
This doesn't modify member state, so it can be marked as const.
2020-08-26 20:11:58 -04:00
f5f30781ae
configure_input_player: Fix modifier scale button mapping
2020-08-26 02:32:32 -04:00
1bd70d73c0
configuration/input: Add support for mouse button clicks
...
Supports the Left, Right, Middle, Backward and Forward mouse buttons.
2020-08-26 02:32:32 -04:00
eb149ec696
controllers/npad: Fix inconsistencies with controller connection statuses
2020-08-26 02:32:32 -04:00
334ef2efdd
controllers/npad: Fix LibNX controller connection statuses
...
This allows homebrew applications to be able to properly detect connected controllers.
2020-08-26 02:32:32 -04:00
e7c174b426
controllers/npad: Fix LedPattern for P1-4
2020-08-26 02:32:32 -04:00
de79897f04
input_common: Fix directional deadzone values
...
The hardware tested value is 0.5 which translates to SHRT_MAX / 2
2020-08-26 02:32:32 -04:00
efa0b7a056
Address feedback
2020-08-26 02:32:32 -04:00
f0fac0c7fb
Project Mjölnir: Part 1
...
Co-authored-by: James Rowe <jroweboy@gmail.com>
Co-authored-by: Its-Rei <kupfel@gmail.com>
2020-08-26 02:32:32 -04:00
f60d5aac3e
gc_poller: Resolve compilation warnings on MSVC
...
We just need to make our intentional implicit truncations explicit.
2020-08-25 23:03:12 -04:00
ccdd84a778
hle/scheduler: Fix data race in is_context_switch_pending
...
As reported by tsan, SelectThreads could write to
is_context_switch_pending holding a mutex while SwitchToCurrent reads it
without holding any.
It is assumed that the author didn't want an atomic here, so the code is
reordered so that whenever is_context_switch_pending is read inside
SwitchToContext, the mutex is locked.
2020-08-26 02:56:05 +00:00
36eade7f4c
hle/kernel: Fix data race in GetCurrentHostThreadID
...
As reported by tsan, host_thread_ids could be read while
any of the RegisterHostThread variants were called.
To fix this, lock the register mutex when yuzu is running in multicore
mode and GetCurrentHostThreadID is called.
2020-08-26 02:52:50 +00:00
f119ef798b
common/thread: Fix data race in is_set
...
As report by tsan, Event::Set can write is_set while WaitFor and friends
are reading from it. To address this issue, make is_set an atomic.
2020-08-26 02:50:51 +00:00
56ac22f737
cpu_interrupt_handler: Misc style changes
2020-08-26 02:43:26 +00:00
ea7bda25ba
cpu_interrupt_handler: Make is_interrupted an atomic
...
Fixes a race condition detected from tsan
2020-08-26 02:43:15 +00:00
902bf6d37d
Merge pull request #4574 from lioncash/const-fn
...
memory_manager: Mark IsGranularRange() as a const member function
2020-08-25 11:24:13 -04:00
dd828607e0
Merge pull request #4563 from lioncash/rcache
...
registered_cache: Make use of designated initializers
2020-08-25 10:07:33 -04:00
b798813eee
Merge pull request #4548 from lioncash/color
...
common/color: Migrate code over to the Common namespace
2020-08-25 10:07:13 -04:00
bb752df736
Merge pull request #4542 from ReinUsesLisp/gpu-init-base
...
video_core: Initialize renderer with a GPU
2020-08-24 22:56:11 -04:00
6fd3a1bf85
Merge pull request #4562 from lioncash/loop
...
cpu_manager: Make use of ranged for where applicable
2020-08-24 17:58:41 -04:00
504175e5b6
common_funcs: Add missing XOR operators to DECLARE_ENUM_FLAG_OPERATORS
...
Ensures that the full set of bitwise operators are available for types
that make use of this macro.
2020-08-24 04:42:43 -04:00
3bfaabdbdd
common/assert: Make use of C++ attribute syntax
...
Normalizes the syntax used for attributes
2020-08-24 04:15:10 -04:00
bafef3d1c9
async_shaders: Mark getters as const member functions
...
While we're at it, we can also mark them as nodiscard.
2020-08-24 01:15:50 -04:00
5bce81c3d6
memory_manager: Mark IsGranularRange() as a const member function
...
This doesn't modify internal member state, so it can be marked as const.
2020-08-24 00:37:57 -04:00
bae4e6c2f5
gl_texture_cache: Take std::string by reference in DecorateViewName()
...
LabelGLObject takes a string_view, so we don't need to make copies of
the std::string.
2020-08-23 23:36:33 -04:00
f3bb52c0a9
video_core/fence_manager: Remove unnecessary includes
...
Avoids pulling in unnecessary things that can cause rebuilds when they
aren't required.
2020-08-23 21:44:50 -04:00
ab350b8975
Merge pull request #4561 from lioncash/key-constexpr
...
key_manager: Make data arrays constexpr
2020-08-23 20:41:05 -04:00
91df2beee3
video_core/host_shaders: Add CMake integration for string shaders
...
Add the necessary CMake code to copy the contents in a string source
shader (GLSL or GLASM) to a header file then consumed by video_core
files.
This allows editting GLSL in its own files without having to maintain
them in source files.
For now, only OpenGL presentation shaders are moved, but we can add
GLASM presentation shaders and static SPIR-V generation through
glslangValidator in the future.
2020-08-23 21:37:20 -03:00
0eaf7e1daa
gl_shader_util: Use std::string_view instead of star pointer
...
This allows us passing any type of string and hinting the length of the
string to the OpenGL driver.
2020-08-23 21:23:54 -03:00
42a00877a2
Merge pull request #4549 from lioncash/files
...
vfs_real: Avoid redundant map lookups
2020-08-23 19:08:36 -04:00
9619964e8c
Merge pull request #4559 from lioncash/webresult
...
web_service: Move web_result.h into web_service
2020-08-23 17:54:43 -04:00
4c1a95ed61
fsp_srv: Resolve -Wunused-but-set-variable warning
...
We can just log out the parameters in the meantime.
2020-08-23 17:16:32 -04:00
01d1b5cdaf
file_sys: Replace inclusions with forward declarations where applicable
...
Same behavior, minus unnecessary inclusions where not necessary.
2020-08-23 17:02:55 -04:00
85db5f4091
fsp_srv: Resolve -Wmaybe_uninitialized warning in OpenSaveDataFileSystem()
...
Initialize id to a deterministic value and also mark the unreachable
cases in the switch with UNREACHABLE().
2020-08-23 16:37:57 -04:00
67a8e73101
registered_cache: Make use of ends_with for string suffix checking
...
Simplifies code.
2020-08-23 11:25:45 -04:00
f83c6e1e0c
registered_cache: Make use of designated initializers
...
Removes the need for comments to indicate the fields being assigned.
2020-08-23 10:26:20 -04:00
cfb7fd395c
Merge pull request #4560 from lioncash/convert
...
core_timing: Resolve sign conversion warning
2020-08-23 02:11:14 -04:00
b62a8ca43e
key_manager: Make data arrays constexpr
...
We can convert these maps into constexpr arrays to eliminate some
runtime static constructors.
2020-08-22 22:47:24 -04:00
544fbd5c84
cpu_manager: Make use of ranged for where applicable
...
We can simplify a few loops by making use of ranged for.
2020-08-22 22:43:19 -04:00
79504f1a39
core_timing: Remove unused header
2020-08-22 22:12:37 -04:00
25cd5d9dda
core_timing: Move clock initializer into constructor initializer list
...
Same behavior, minus unnecessary zeroing out of the pointer.
2020-08-22 20:26:48 -04:00
2624b1eae6
core_timing: Resolve sign conversion warning
...
This constant is only ever assigned to downcount, which is a s64, not a
u64.
2020-08-22 20:26:45 -04:00
ca5ed50655
web_service: Move web_result.h into web_service
...
This is the only place it's actively used. It's also more appropriate
for web-related structures to be within the web service target.
Especially given this one doesn't rely on anything in the common
library.
2020-08-22 19:29:54 -04:00
da53bcee60
video_core: Initialize renderer with a GPU
...
Add an extra step in GPU initialization to be able to initialize render
backends with a valid GPU instance.
2020-08-22 01:51:45 -03:00
baff9ffcac
Merge pull request #4521 from lioncash/optionalcache
...
gl_shader_disk_cache: Make use of std::nullopt where applicable
2020-08-21 23:56:55 -04:00
66ac7cf730
Merge pull request #4541 from MerryMage/yolo
...
dynarmic: Add unsafe optimizations
2020-08-21 23:06:21 -04:00
53fbf8e206
Merge pull request #4523 from lioncash/self-assign
...
macro-interpreter: Resolve -Wself-assign-field warning
2020-08-21 18:25:53 -04:00
aed6011d7c
vk_state_tracker: Fix primitive topology
...
State track the current primitive topology with a regular comparison
instead of using dirty flags.
This fixes a bug in dirty flags for this particular state and it also
avoids unnecessary state changes as this property is stored in a
frequently changed bit field.
2020-08-20 23:07:30 -03:00
c5a78f4480
vk_device: Use Vulkan 1.0 properly
...
Enable the required capabilities to use Vulkan 1.0 without validation
errors and disable those that are not compatible with it.
2020-08-20 16:55:22 -03:00
29a0ca2391
renderer_vulkan: Create a Vulkan 1.0 instance when 1.1 is not available
...
This commit doesn't make yuzu compatible with Vulkan 1.0 yet, it only
creates an 1.0 instance.
2020-08-20 16:55:22 -03:00
3ea3de4ecd
Merge pull request #4546 from lioncash/telemetry
...
common/telemetry: Migrate namespace into the Common namespace
2020-08-20 14:29:13 -04:00
3b8a8cf825
Merge pull request #4547 from lioncash/header-concept
...
common/concepts: Move <type_traits> include out of the Common namespace
2020-08-19 23:29:45 -04:00
acbae572d3
Revert "common/time_zone: Simplify GetOsTimeZoneOffset()"
2020-08-19 18:27:31 -04:00
b1fa647f28
Merge pull request #4539 from lioncash/disc
...
common: Silence two discarded result warnings
2020-08-18 22:03:09 -04:00
2d2e235bcf
Merge pull request #4522 from lioncash/vulk-copy
...
vulkan/wrapper: Avoid unnecessary copy in EnumerateInstanceExtensionProperties()
2020-08-18 19:31:35 -04:00
f6bb905182
common/telemetry: Migrate namespace into the Common namespace
...
Migrates the Telemetry namespace into the Common namespace to make the
code consistent with the rest of our common code.
2020-08-18 15:08:32 -04:00
551882e512
vfs_real: Resolve sign conversion warnings
2020-08-18 14:58:33 -04:00
ed9ae5a977
vfs_real: Avoid redundant map lookups
...
Avoids some trivially avoidable map lookups by keeping the result of
find operations around and querying them.
2020-08-18 14:58:29 -04:00
e864aa25d5
common/color: Migrate code over to the Common namespace
...
No external code makes use of this header, so we can freely change the
namespace.
2020-08-18 14:27:41 -04:00
999fc2fece
common/concepts: Move <type_traits> include out of the Common namespace
...
This is a compiler/linker error waiting to happen.
2020-08-18 14:24:54 -04:00
bea9ed2548
Merge pull request #4381 from Morph1984/fix-open-folder-installed-title
...
main: Fix Open Save/Mod Locations for installed titles
2020-08-18 12:54:06 -04:00
00573fb2c9
Merge pull request #4532 from lioncash/object-name
...
configuration_shared: Simplify name lookup in highlighting functions
2020-08-18 00:45:02 -04:00
56c6a5def8
Merge pull request #4535 from lioncash/fileutil
...
common/fileutil: Convert namespace to Common::FS
2020-08-17 22:35:30 -04:00
0c885249df
Merge pull request #4537 from lioncash/tz
...
common/time_zone: Simplify GetOsTimeZoneOffset()
2020-08-17 14:27:02 -04:00
3472c00b3b
Merge pull request #4540 from lioncash/tr3
...
configure_hotkeys: Don't translate empty strings
2020-08-17 12:24:58 -04:00
0530dd6ea1
Merge pull request #4494 from lioncash/transcode
...
aes_util: Make use of non-template variant of Transcode
2020-08-17 03:50:35 -04:00
d8a90e6536
Merge pull request #4531 from lioncash/overload
...
yuzu: Make use of qOverload where applicable
2020-08-17 04:13:14 -03:00
cbaf1bc711
Merge pull request #4443 from ameerj/vk-async-shaders
...
vulkan_renderer: Async shader/graphics pipeline compilation
2020-08-17 15:06:11 +10:00
bbb5623f52
Merge pull request #4515 from lat9nq/pgs-menubar-config
...
main: Add an option to modify the currrent game's configuration
2020-08-17 01:03:39 -04:00
a91acd5365
Merge pull request #4520 from lioncash/pessimize
...
async_shaders: Resolve -Wpessimizing-move warning
2020-08-17 14:36:05 +10:00
fde8102a41
Remove unneeded newlines, optional Registry in shader params
...
Addressing feedback from Rodrigo
2020-08-16 16:33:21 -04:00
f49ffdd648
Morph: Update worker allocation comment
...
Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>
2020-08-16 12:02:22 -04:00
1b829fbd7a
move thread 1/4 count computation into allocate workers method
2020-08-16 12:02:22 -04:00
31a76410e8
Address feedback, add shader compile notifier, update setting text
2020-08-16 12:02:22 -04:00
c02464f64e
Vk Async Worker directly emplace in cache
2020-08-16 12:02:22 -04:00
4539073ce1
Address feedback. Bruteforce delete duplicates
2020-08-16 12:02:22 -04:00
6ac97405df
Vk Async pipeline compilation
2020-08-16 12:02:22 -04:00
80ac1331b5
Preliminary effects
2020-08-17 01:23:55 +10:00
836ec9176a
dynarmic: Add unsafe optimizations
2020-08-16 14:15:39 +01:00
e23289d869
configure_hotkeys: Don't translate empty strings
...
There's no need to translate an empty string. This just gives
translators unnecessary work.
2020-08-16 08:13:25 -04:00
c4ed791164
common/fileutil: Convert namespace to Common::FS
...
Migrates a remaining common file over to the Common namespace, making it
consistent with the rest of common files.
This also allows for high-traffic FS related code to alias the
filesystem function namespace as
namespace FS = Common::FS;
for more concise typing.
2020-08-16 06:52:40 -04:00
d09456fc41
common: Silence two discarded result warnings
...
These are intentionally discarded internally, since the rest of the
public API allows querying success. We want all non-internal uses of
these functions to be explicitly checked, so we can signify that we
intentionally want to discard the return values here.
2020-08-16 06:17:33 -04:00
fe97d34156
common/time_zone: Simplify GetOsTimeZoneOffset()
...
We can simplify this function down into a single line with the use of
fmt. A benefit with the fmt approach is that the fmt variant of
localtime is thread-safe as well, making GetOsTimeZoneOffset()
thread-safe as well.
2020-08-16 03:58:47 -04:00
dbb1cbce67
yuzu: Resolve -Wextra-semi warnings
...
While we're in the same area, we can ensure GameDir member variables are
always initialized to consistent values.
2020-08-16 03:58:29 -04:00
db96034ea4
Merge pull request #4528 from lioncash/discard
...
common: Make use of [[nodiscard]] where applicable
2020-08-16 01:47:54 -04:00
404362e1b0
Merge pull request #4519 from lioncash/semi
...
maxwell_3d: Resolve -Wextra-semi warning
2020-08-16 00:55:15 -04:00
9f972b7d01
main: Add an option to modify the currrent game's configuration
...
Creates a new entry in the Emulation menu called "Configure Current Game..." that is only available if a game is currently being executed in yuzu. When selected, it opens the game properties dialog for the current game.
Thanks to @BSoDGamingYT for reminding me to do this.
2020-08-15 20:28:48 -04:00
1ee060ca0d
common/compression: Roll back std::span changes
...
Seems like all compilers don't support std::span yet.
2020-08-15 17:17:56 -04:00
df72480395
common: Make use of [[nodiscard]] where applicable
...
Now that clang-format makes [[nodiscard]] attributes format sensibly, we
can apply them to several functions within the common library to allow
the compiler to complain about any misuses of the functions.
2020-08-15 17:17:52 -04:00
2b601e8636
Merge pull request #4526 from lioncash/core-semi
...
core: Resolve several -Wextra-semi warnings
2020-08-15 02:14:11 -04:00
e6f9231ef0
Merge pull request #4527 from lioncash/pessimizing2
...
software_keyboard: Resolve a pessimizing move warning
2020-08-15 02:13:44 -04:00
cb6808b4d0
Merge pull request #4492 from lioncash/linkage
...
system_control: Make functions internally linked where applicable
2020-08-15 02:11:49 -04:00
2aabd1eb05
Merge pull request #4463 from lioncash/lockdiscard
...
kernel/scheduler: Mark SchedulerLock constructor as nodiscard
2020-08-15 01:31:23 -04:00
feb243b08d
Merge pull request #4416 from lioncash/span
...
lz4_compression/zstd_compression: Make use of std::span in interfaces
2020-08-15 00:53:11 -04:00
2dace90346
Merge pull request #4453 from ReinUsesLisp/block-to-linear
...
textures/decoders: Fix block linear to pitch copies
2020-08-14 19:52:12 -04:00
fe86109877
configuration_shared: Simplify name lookup in highlighting functions
...
We can query the given object name directly from the widget itself. This
removes any potential for forgetting to change the name if the widget
gets renamed and makes the API much simpler (just pass in the widget,
and not worry about its name).
2020-08-14 14:17:02 -04:00
969a4cc4da
yuzu: Make use of qOverload where applicable
...
Eliminates a verbose function cast.
2020-08-14 14:12:55 -04:00
b14277ef97
time_zone_content_manager: Collapse auto and default case
...
Prevents a useless self-assignment from occurring.
2020-08-14 10:58:58 -04:00
1f1c3bddc0
Disable biquad filter
2020-08-14 23:20:20 +10:00
03d5a5d9de
software_keyboard: Resolve a pessimizing move warning
...
A std::vector created in place like this is already an rvalue and
doesn't need to be moved.
2020-08-14 09:14:54 -04:00
2296e921d2
core: Resolve several -Wextra-semi warnings
...
We can amend one of the cascade macros to require semicolons in order to
compile. In other cases, we can just remove the superfluous semicolons.
2020-08-14 09:09:20 -04:00
dcc5562cd5
shader/memory: Amend UNIMPLEMENTED_IF_MSG without a message
...
We need to provide a message for this variant of the macro, so we can
simply log out the type being used.
2020-08-14 08:38:37 -04:00
34ec64233a
macro-interpreter: Resolve -Wself-assign-field warning
...
This was assigning the field to itself, which is a no-op. The size
doesn't change between its initial assignment and this one, so this is a
safe change to make.
2020-08-14 08:26:50 -04:00
167d36ec3c
vulkan/wrapper: Avoid unnecessary copy in EnumerateInstanceExtensionProperties()
...
Given this is implicitly creating a std::optional, we can move the
vector into it.
2020-08-14 08:23:49 -04:00
c8135b3c18
gl_shader_disk_cache: Make use of std::nullopt where applicable
...
Allows the compiler to avoid unnecessarily zeroing out the internal
buffer of std::optional on some implementations.
2020-08-14 08:20:44 -04:00
6b13d08822
async_shaders: Resolve -Wpessimizing-move warning
...
Prevents pessimization of the move constructor (which thankfully didn't
actually happen in practice here, given std::thread isn't copyable).
2020-08-14 08:16:50 -04:00
83d8bf9af9
maxwell_3d: Resolve -Wextra-semi warning
...
Semicolons after a function definition aren't necessary.
2020-08-14 08:13:41 -04:00
1b3d86c02f
Reworked ADPCM decoder to allow better streaming
2020-08-14 21:04:28 +10:00
a93f6e51d3
emu_window: Mark Scoped constructor and Acquire() as nodiscard
...
Ensures that callers make use of the constructor, preventing bugs from
silently occurring.
2020-08-14 04:43:44 -04:00
f808258ed9
kernel/scheduler: Mark SchedulerLock constructor as nodiscard
...
Allows the compiler to warn about cases where the constructor is used
but then immediately discarded, which is a potential cause of
locking/unlocking bugs.
2020-08-14 04:43:44 -04:00
e050594706
Merge pull request #4495 from lioncash/conv
...
cheat_engine: Resolve implicit bool->u64 conversion
2020-08-14 03:10:17 -03:00
a9de967fa3
Merge pull request #4514 from Morph1984/worker-alloc
...
gl_shader_cache: Use std::max() for determining num_workers
2020-08-13 17:06:57 -04:00
ff0b14ee62
Merge pull request #4511 from lioncash/build2
...
General: Tidy up clang-format warnings part 2
2020-08-13 15:13:21 -04:00
b724a4d90c
General: Tidy up clang-format warnings part 2
2020-08-13 14:19:08 -04:00
e0ff98dd34
gl_shader_cache: Use std::max() for determining num_workers
...
Does not allocate more threads than available in the host system for boot-time shader compilation and always allocates at least 1 thread if hardware_concurrency() returns 0.
2020-08-12 09:23:34 -04:00
a8ffe6eee4
Merge pull request #4497 from lioncash/freezer-alg
...
freezer: Make use of std::erase_if
2020-08-11 23:07:17 -04:00
e143adc3cf
Merge pull request #4493 from jbeich/dragonfly
...
common/virtual_buffer: drop unused includes
2020-08-11 12:52:50 -04:00
4605e4d6ff
Merge pull request #4502 from lioncash/build
...
General: Tidy up clang-format warnings
2020-08-11 11:04:05 -04:00
f00641459e
textures/decoders: Fix block linear to pitch copies
...
There were two issues with block linear copies. First the swizzling was
wrong and this commit reimplements them.
The other issue was that these copies are generally used to download
render targets from the GPU and yuzu was not downloading them from
host GPU memory unless the extreme GPU accuracy setting was selected.
This commit enables cached memory reads for all accuracy levels.
- Fixes level thumbnails in Super Mario Maker 2.
2020-08-10 20:45:03 -03:00
257b1d2c4b
Merge pull request #4496 from lioncash/ce-desig
...
cheat_engine: Make use of designated initializers
2020-08-10 13:53:43 -04:00
d6672501ac
Remove UI changes
...
This PR is now only the Analog devices handling the range value defaulting at 100%
2020-08-10 12:46:14 -04:00
9c6ae697f5
Add range slider functionality for gc adapter
2020-08-10 12:46:14 -04:00
8928aa3008
undo unnecessary newlines, slider range 50-150
2020-08-10 12:46:14 -04:00
504095cea9
Address c++20 warning, fix inaccurate range text display when slide == 0
2020-08-10 12:46:14 -04:00
ed51c2abda
Add range slider for analog sticks
2020-08-10 12:46:14 -04:00
acfd771e79
Merge pull request #4491 from lioncash/unused-vars
...
kernel: Remove unused variables
2020-08-10 12:04:30 -04:00
664019954a
Merge pull request #4488 from lioncash/file
...
vfs_vector: Make creation of array vfs files less verbose
2020-08-09 17:19:34 -04:00
1c3490a8db
General: Tidy up clang-format warnings
2020-08-08 20:08:44 -04:00
f14bb61acd
Merge pull request #4448 from Morph1984/fix-entries
...
game_list_worker: Do not clear entries when > 1 gamedir is present
2020-08-07 17:11:52 -04:00
929fc849e9
Merge pull request #4457 from ogniK5377/SetScreenShotPermission
...
am: Unstub SetScreenShotPermission
2020-08-07 09:34:20 -04:00
5429ea0e69
Merge pull request #4389 from ogniK5377/redundant-format-type
...
video_core: Remove redundant pixel format type
2020-08-07 09:33:58 -04:00
8e86fa7e60
common/concepts: Rename IsBaseOf to DerivedFrom
...
This makes it more inline with its currently unavailable standardized
analogue std::derived_from.
While we're at it, we can also make the template match the requirements
of the standardized variant as well.
2020-08-07 08:09:57 -04:00
f5d538f118
Merge pull request #4483 from lioncash/constexpr-hex
...
partition_data_manager: Make data arrays constexpr
2020-08-06 23:14:14 -04:00
5cc2f99fab
Merge pull request #4490 from lioncash/arbiter
...
address_arbiter/scheduler: Resolve sign conversion warnings
2020-08-06 22:28:11 -04:00
61cd7eb47d
freezer: Move entry finding to its own function
...
Cleans up the callsites in other functions.
2020-08-06 03:11:21 -04:00
06ab28263b
freezer: Take address values by value
...
VAddr will always be 64-bit, so there's no need to take a trivial
primitive alias by reference.
2020-08-06 03:04:54 -04:00
253a17451b
freezer: Make use of std::erase_if
...
With C++20 we can simplify the erasing idiom.
2020-08-06 03:03:05 -04:00
5b89291308
cheat_engine: Resolve implicit bool->u64 conversion
...
We can just return zero here.
2020-08-06 02:55:47 -04:00
df96a214ae
cheat_engine: Make use of designated initializers
...
Same behavior, but makes the member being assigned obvious.
2020-08-06 02:48:13 -04:00
4f2acc54f5
partition_data_manager: Update master key hashes
...
Fills in some hashes that were previously unhandled.
2020-08-06 02:42:01 -04:00
7f0f37fca7
partition_data_manager: Make data arrays constexpr
...
Previously the constructor for all of these would run at program
startup, consuming time before the application can enter main().
This is also particularly dangerous, given the logging system wouldn't
have been initialized properly yet, yet the program would use the logs
to signify an error.
To rectify this, we can replace the literals with constexpr functions
that perform the conversion at compile-time, completely eliminating the
runtime cost of initializing these arrays.
2020-08-06 02:41:58 -04:00
04bb47f57f
partition_data_manager: Eliminate magic value
...
We can use sizeof to make it obvious at the call site where the value is
coming from.
2020-08-06 02:34:10 -04:00
09f884b7bd
aes_util: Make use of non-template variant of Transcode
...
Same behavior, less template instantiations.
2020-08-06 02:31:19 -04:00
d37f0b29e2
Fix thread naming on Linux, which limits names to 15 bytes.
...
- In `SetCurrentThreadName`, when on Linux, truncate to 15 bytes, as (at
least on glibc) `pthread_set_name_np` will otherwise return `ERANGE` and
do nothing.
- Also, add logging in case `pthread_set_name_np` returns an error
anyway. This is Linux-specific, as the Apple and BSD versions of
`pthread_set_name_np return `void`.
- Change the name for CPU threads in multi-core mode from
"yuzu:CoreCPUThread_N" (19 bytes) to "yuzu:CPUCore_N" (14 bytes) so it
fits into the Linux limit. Some other thread names are also cut off,
but I didn't bother addressing them as you can guess them from the
truncated versions. For a CPU thread, truncation means you can't see
which core it is!
2020-08-05 20:34:49 -07:00
1cc0e4b4d8
Merge pull request #4489 from lioncash/typesafe
...
ipc_helpers: Only allow trivially copyable objects with PushRaw() and PopRaw()
2020-08-05 23:20:23 -04:00
35c1607f23
Merge pull request #4484 from lioncash/aesutil
...
aes_util: Allow SetIV() to be non-allocating
2020-08-05 22:35:41 -04:00
d888ac7d20
Merge pull request #4477 from lioncash/log-desig
...
logging/backend: Make use of designated initializers
2020-08-05 22:34:12 -04:00
238208ee30
common/virtual_buffer: drop unused includes
...
On DragonFly and NetBSD build fails with
src/common/virtual_buffer.cpp
src/common/virtual_buffer.cpp:16:10: fatal error: sys/sysinfo.h: No such file or directory
#include <sys/sysinfo.h>
^~~~~~~~~~~~~~~
2020-08-05 21:36:35 +00:00
61678c4e9f
Merge pull request #4475 from lioncash/bqueue
...
buffer_queue: Make use of designated initializers/std::nullopt where applicable
2020-08-05 16:56:46 -04:00
e8868c2ed1
Merge pull request #4479 from lioncash/concepts
...
CMakeLists: Resolve #4478
2020-08-05 16:18:08 -04:00
87c64c41d2
system_control: Make functions internally linked where applicable
...
These functions are only ever used internally as implementation details
for GenerateRandomRange(), so these can be given internal linkage.
2020-08-05 15:34:27 -04:00
a10d64ea79
kernel: Remove unused variables
...
Resolves a few compiler warnings.
2020-08-05 15:19:48 -04:00
9893da8e2c
scheduler: Resolve sign conversion warning
2020-08-05 15:12:29 -04:00
1a45b15a8c
address_arbiter: Resolve sign conversion warning
...
Makes our type conversion explicit.
2020-08-05 15:07:19 -04:00
4a2d9c6454
Merge pull request #4444 from lioncash/volatile
...
common/atomic_ops: Don't cast away volatile from pointers
2020-08-05 14:22:36 -04:00
a77ee63f65
ipc_helpers: Only allow trivially copyable objects with PushRaw() and PopRaw()
...
It's undefined behavior to use non-trivially copyable objects with
std::memcpy, so we can add asserts to catch usages of these at
compile-time.
2020-08-05 14:08:28 -04:00
0a5456feb9
vfs_vector: Make creation of array vfs files less verbose
...
We can add a helper function to make creation of these files nicer.
While we're at it, we can eliminate an unnecessary std::array copy in
the constructor. This makes the overhead on some of these functions way
less intensive, given some arrays were quite large.
e.g. The timezone location names are 9633 bytes in size.
2020-08-05 12:37:00 -04:00
07691f994a
Merge pull request #4466 from ogniK5377/loader-type-safe
...
loader: Make IdentifyFile typesafe
2020-08-05 12:34:25 -04:00
cf946312ca
main: Fallback to loader if no control nca is found with patch manager
...
In some rare instances, the patch manager is not able to find a control nca, fallback to the previous method of parsing a control nca through the loader if this occurs.
2020-08-04 21:14:20 -04:00
1146049de0
main: Fix Open Save/Mod Locations for installed titles
...
Previously NAND/SDMC installed titles would open device saves when they are supposed to be user saves. This is due to the control nca not being read and thus returns 0 for both GetDefaultNormalSaveSize() and GetDeviceSaveDataSize(). Fix this by utilizing the patch manager to read the control nca.
2020-08-04 21:14:20 -04:00
123024cea2
game_list_worker: Do not clear entries when > 1 gamedir is present
...
Previously the map of entries was being cleared while looping through each game directory, this resulted into all game directories except the last game dir to lose content metadata information. Fix this by clearing the entries only once.
2020-08-04 21:13:35 -04:00
142930e609
Merge pull request #4476 from lioncash/tz
...
time_zone_binary: Make use of designated initializers
2020-08-04 18:56:28 -04:00
ba9ed7b1fe
Merge pull request #4401 from ogniK5377/GetIndirectLayerImageRequiredMemoryInfo
...
vi: IApplicationDisplayService:GetIndirectLayerImageRequiredMemoryInfo
2020-08-04 18:45:11 -04:00
f11628b9b7
Merge pull request #4430 from bunnei/new-gpu-vmm
...
hle: nvdrv: Rewrite of GPU memory management.
2020-08-04 18:44:26 -04:00
efd1b57d03
Merge pull request #4445 from Morph1984/async-threads
...
renderer_opengl: Use 1/4 of all threads for async shader compilation
2020-08-04 18:43:42 -04:00
c71d05de84
Merge pull request #4450 from Morph1984/fix-gamelist-scanning
...
game_list_worker: Fix game list subdirectory scanning
2020-08-04 18:43:17 -04:00
ecbee11829
Merge pull request #4472 from lioncash/const-get
...
perf_stats: Mark GetMeanFrametime() as const
2020-08-04 07:00:23 -07:00
0ae267bf77
Merge pull request #4469 from lioncash/missing
...
vk_texture_cache: Silence -Wmissing-field-initializer warnings
2020-08-04 06:59:51 -07:00
741cbbdc0e
Merge pull request #4470 from lioncash/qualifier
...
patch_manager: Resolve -Wignored-qualifier warnings
2020-08-04 14:09:48 +10:00
723314b682
Merge pull request #4481 from lioncash/cpp-dep
...
yuzu: Resolve C++20 deprecation warnings related to lambda captures
2020-08-04 14:06:07 +10:00
25fb7cd16d
Merge pull request #4474 from lioncash/hle-profile
...
profile_manager: Make use of designated initializers
2020-08-04 13:51:15 +10:00
c6e5a36452
Merge pull request #4473 from lioncash/cheat-desig
...
dmnt_cheat_vm: Make use of designated initializers
2020-08-03 18:07:17 -07:00
0dbb95c42d
Merge pull request #4456 from Morph1984/stub-really-long-fs-func
...
fsp-srv: Stub Read/WriteSaveDataFileSystemExtraDataWithMaskBySaveDataAttribute
2020-08-03 18:06:48 -07:00
15660bd857
aes_util: Allow SetIV to be non-allocating
...
In a few places, the data to be set as the IV is already within an array.
We shouldn't require this data to be heap-allocated if it doesn't need
to be. This allows certain callers to reduce heap churn.
2020-08-03 14:29:58 -04:00
b2911421ec
Merge pull request #4480 from lioncash/optimize
...
tests/core_timing: Remove pragma optimize(off)
2020-08-03 11:27:52 -07:00
9808f244cc
Merge pull request #4482 from lioncash/ldr-sign
...
service/ldr: Resolve sign mismatch warnings
2020-08-03 11:27:13 -07:00
a971667d1f
Merge pull request #4468 from lioncash/regcache
...
registered_cache: Resolve -Wmaybe_uninitialized warnings
2020-08-03 11:26:45 -07:00
94c1689ef3
Merge pull request #4471 from ogniK5377/sm-getservice-concept
...
sm: Make use of IsBaseOf for GetService
2020-08-03 11:11:22 -07:00
570150bc86
perf_stats: Make use of designated initializers
...
Same behavior, but allows us to avoid a now-unnecessary zero
initialization.
2020-08-03 12:33:40 -04:00
d767be65be
perf_stats: Mark GetMeanFrametime() as const
...
The general pattern is to mark mutexes as mutable when it comes to
matters of constness, given the mutex acts as a transient member of a
data structure.
2020-08-03 12:33:35 -04:00
06809ad7bc
vulkan: Silence more -Wmissing-field-initializer warnings
2020-08-03 12:28:57 -04:00
b249e4e0ce
yuzu: Resolve C++20 deprecation warnings related to lambda captures
...
C++20 deprecates capturing the this pointer via the '=' capture.
Instead, we replace it or extend the capture specification.
2020-08-03 11:54:04 -04:00
f525da56e5
service/ldr: Resolve sign mismatch warnings
...
We were performing an int < size_t comparison. We can just correct the
type of the induction variable.
2020-08-03 11:48:16 -04:00
dd2ff23621
CMakeLists: Resolve #4478
...
This switch is enabled by default in all recent versions of GCC and
Clang.
2020-08-03 11:21:24 -04:00
e1ab72a0ea
tests/core_timing: Remove pragma optimize(off)
...
I made a review comment about this in the PR that this was introduced
in (#3955 , commit 71c4779211
2020-08-03 11:12:55 -04:00
3697fc8d14
Merge pull request #4467 from lioncash/mode
...
file_sys/mode: Make use of DECLARE_ENUM_FLAG_OPERATORS with Mode
2020-08-03 08:07:56 -07:00
04ca1ed2bd
time_zone_binary: Make use of designated initializers
2020-08-03 10:42:38 -04:00
8725b37a35
logging/backend: Make use of designated initializers
...
Same behavior, less code.
2020-08-03 10:37:48 -04:00
9b837c6069
buffer_queue: Make use of std::nullopt
...
Allows compilers to eliminate unnecessary zeroing out of the optional's
buffer.
2020-08-03 09:31:51 -04:00
24bd068a08
buffer_queue: Make use of designated initializers
2020-08-03 09:31:51 -04:00
b9831fd80a
profile_manager: Make use of std::nullopt
...
Allows some implementations to completely avoid unnecessarily zeroing
out the internal buffer.
2020-08-03 09:03:42 -04:00
3fcaf937d2
profile_manager: Make use of designated initializers
...
More compact code.
2020-08-03 09:01:31 -04:00
c883666045
dmnt_cheat_vm: Make use of designated initializers
...
Allows for more compact code.
2020-08-03 08:50:51 -04:00
2b8ae009a0
file_sys/mode: Make use of DECLARE_ENUM_FLAG_OPERATORS with Mode
...
Same behavior, minus a hand-rolled operator.
2020-08-03 07:52:36 -04:00
6a0b77996b
sm: Make use of IsBaseOf for GetService
2020-08-03 21:46:14 +10:00
1c6d3ba397
patch_manager: Resolve -Wignored-qualifier warnings
...
Top level const will always be ignored in this case, so it can be
removed.
2020-08-03 07:42:56 -04:00
4ca0014479
registered_cache: Resolve -Wmaybe_uninitialized warnings
...
While we're at it, we can avoid a redundant map lookup.
2020-08-03 07:34:46 -04:00
a5af1161c9
Place in anonymous namespace
2020-08-03 21:31:28 +10:00
6cfff2c3f6
loader: Make IdentifyFile typesafe
...
Relies on #4465 for concept.h Common::IsBaseOf
2020-08-03 21:31:27 +10:00
9b75481755
ipc: Allow all trivially copyable objects to be passed directly into WriteBuffer ( #4465 )
...
* ipc: Allow all trivially copyable objects to be passed directly into WriteBuffer
With the support of C++20, we can use concepts to deduce if a type is an STL container or not.
* More agressive concept for stl containers
* Add -fconcepts
* Move to common namespace
* Add Common::IsBaseOf
2020-08-03 07:28:54 -04:00
6c7292de33
Merge pull request #4263 from lat9nq/fix-screencaps-2
...
screenshots: Option to save screenshots immediately in a specified directory + Linux workaround
2020-08-03 21:00:14 +10:00
0ca42c806f
Merge pull request #4439 from lioncash/cpu
...
cpu_manager: Remove redundant std::function declarations
2020-08-03 20:58:31 +10:00
50d8264833
Merge pull request #4438 from lioncash/localizing
...
yuzu/main: Remove redundant usages of QStringLiteral("")
2020-08-03 20:58:00 +10:00
0947f613b1
mix buffer depopping
2020-08-01 16:25:08 +10:00
fc86cb4ca2
minor nits
2020-07-31 11:02:59 -04:00
e586921c28
am: Unstub SetScreenShotPermission
2020-08-01 00:44:14 +10:00
1241020093
fsp-srv: Stub Read/WriteSaveDataFileSystemExtraDataWithMaskBySaveDataAttribute
...
Stub these 2 service commands required for Animal Crossing: New Horizons Update 1.4.0
2020-07-30 15:39:44 -04:00
45fd67c109
fs: Rename SaveDataDescriptor to SaveDataAttribute
2020-07-30 15:29:39 -04:00
0c262f8ac2
Merge pull request #4392 from lioncash/guard
...
compatible_formats: Add missing header guard
2020-07-31 01:08:56 +10:00
1b8fe7073b
adpcm streaming
2020-07-30 18:16:57 +10:00
4c0f6f1bc8
Merge pull request #4396 from lioncash/comma
...
surface_params: Replace questionable usages of the comma operator with semicolons
2020-07-29 19:55:44 -04:00
e0d02d032b
game_list_worker: Fix game list subdirectory scanning
...
Oddly enough the scan that feeds the manual content provider is hardcoded to scan 2 nested directories deep.
This effectively rendered the scan subdirectories setting useless as the manual content provider cannot find any games located more than 2 nested directories deep.
Furthermore, this behavior causes game files to be picked up by the manual content provider even if scan subdirectories is disabled.
FIx this by utilizing the behavior described when populating the game list for populating the content provider.
2020-07-29 09:22:29 -04:00
e59d17167d
main: Add support for removing SDMC installed titles
2020-07-29 06:50:30 -04:00
ed46f3c62a
xts_archive: Check if the file is nullptr prior to parsing
...
Fixes an access violation where the file no longer exists at the specified path while being parsed.
2020-07-29 06:50:30 -04:00
2ec852dd9f
registered_cache: Add support for removing folder ncas
2020-07-29 06:50:30 -04:00
b317942131
game_list: Limit context menu options for homebrew
...
Hides the following options when the title id is 0:
- Open Save Location
- Open Mod Data Location
- Open Transferable Shader Cache
- All removal options except Remove Custom Configuration
2020-07-29 06:50:30 -04:00
cd814bfdfe
main: Remove assert for opening savedata when program_id = 0
2020-07-29 06:50:30 -04:00
f78e44762a
main: Silence [[fallthrough]] warning
2020-07-29 06:50:30 -04:00
ef02370816
main: Split removal cases into their individual functions and address feedback
2020-07-29 06:50:30 -04:00
85e1facfe6
main: Connect game list remove signals to removal functions
2020-07-29 06:50:30 -04:00
de6b852dc2
game_list: Add "Remove" context menu
...
Adds the following actions:
- Remove Installed Update
- Remove All Installed DLC
- Remove Shader Cache
- Remove Custom Configuration
- Remove All Installed Contents
2020-07-29 06:50:30 -04:00
b205b12e75
Merge pull request #4442 from lioncash/devicemem
...
device_memory: Remove unused system member
2020-07-28 13:03:30 -07:00
8d42456dc2
configure_graphics: Remove Force 30 FPS mode
...
The introduction of multicore rendered this setting non-functional as timing code was changed.
This removes the setting entirely.
2020-07-28 08:07:26 -04:00
e8f22730d1
renderer_opengl: Use 1/4 of all threads for async shader compilation
2020-07-28 05:08:27 -04:00
e3f0c93230
common/atomic_ops: Don't cast away volatile from pointers
...
Preserves the volatility of the pointers being casted.
2020-07-28 04:36:53 -04:00
bc699ace15
service/bsd: Handle Poll with no entries accurately
...
Testing shows that Poll called with zero entries returns -1 and signals
an errno of zero.
2020-07-28 01:51:47 -03:00
f7d59f3e0e
services/bsd: Implement most of bsd:s
...
This implements: Socket, Poll, Accept, Bind, Connect, GetPeerName,
GetSockName, Listen, Fcntl, SetSockOpt, Shutdown, Recv, RecvFrom,
Send, SendTo, Write, and Close
The implementation was done referencing: SwIPC, switchbrew, testing
with libnx and inspecting its code, general information about bsd
sockets online, and analysing official software.
Not everything from these service calls is implemented, but everything
that is not implemented will be logged in some way.
2020-07-28 01:48:42 -03:00
2c67bbf609
service/sockets: Add worker pool abstraction
...
Manage worker threads with an easy to use abstraction.
We can expand this to support thread deletion in the future.
2020-07-28 01:47:03 -03:00
5692c48ab7
service/sockets: Add worker abstraction to execute blocking calls asynchronously
...
This abstraction allows executing blocking functions (like recvfrom on a
socket configured for blocking) without blocking the service thread.
It is intended to be used with SleepClientThread.
2020-07-28 01:47:03 -03:00
80b4bd3583
service/sockets: Add translate functions
...
These functions translate from Network enumerations/structures to guest
enumerations/structures and viceversa.
2020-07-28 01:47:03 -03:00
22263ccaa4
service/sockets: Add enumerations and structures
...
Add guest enumerations and structures used in socket services
2020-07-28 01:47:03 -03:00
ef8acc9c3d
services/nifm: Implement GetCurrentIpAddress
...
This is trivially implemented using the Network abstraction
- Used by ftpd
2020-07-28 01:47:03 -03:00
2258f33ee4
device_memory: Remove unused system member
...
This isn't used by anything in particular, so it can be removed.
2020-07-27 23:37:49 -04:00
989ad52dc1
cpu_manager: Remove redundant std::function declarations
...
We can just return the function directly. Making for less reading.
2020-07-27 21:57:05 -04:00
db94457205
Update src/core/hle/service/nvdrv/devices/nvmap.cpp
...
Co-authored-by: LC <mathew1800@gmail.com>
2020-07-27 18:27:20 -07:00
a7af349dae
core_timing: Make use of uintptr_t to represent user_data
...
Makes the interface future-proofed for supporting other platforms in the event we ever support platforms with differing pointer sizes. This way, we have a type in place that is always guaranteed to be able to represent a pointer exactly.
2020-07-27 21:21:01 -04:00
2e303095d5
yuzu/main: Remove redundant usages of QStringLiteral("")
...
An empty QStringLiteral can more efficiently be replaced with an empty
QString.
2020-07-27 21:04:17 -04:00
6b35317ff3
Merge pull request #4419 from lioncash/initializer
...
vulkan: Resolve -Wmissing-field-initializer warnings
2020-07-27 15:52:03 -07:00
f97c2cdd0b
Merge pull request #4434 from CrazyMax/lang_unused_var
...
AM: GetDesiredLanguage: remove unused variable
2020-07-27 12:37:52 -07:00
d51afc4efb
Merge pull request #4432 from bylaws/patch-1
...
video_core/gpu: Correct the size of the puller registers
2020-07-27 05:25:49 -03:00
1ffff4dab2
remove unused variable;
2020-07-27 10:36:26 +03:00
99d191d80d
Merge pull request #4431 from kelnos/fix-exit-crash
...
GCAdapter: only join worker thread if running & joinable
2020-07-26 18:03:37 -07:00
d840ed90e1
GCAdapter: only join worker thread if running & joinable
2020-07-26 14:54:02 -07:00
f490b4545d
video_core/gpu: Correct the size of the puller registers
...
The puller register array is made up of u32s however the `NUM_REGS` value is the size in bytes, so switch it to avoid making the struct unnecessary large. Also fix a small typo in a comment.
2020-07-26 22:26:29 +01:00
156bf5b297
config: Make the save-as identifier more consistent
...
Solves an issue with restoring the value upon reloading program.
2020-07-26 13:31:00 -04:00
08f02836d8
Merge pull request #4426 from lioncash/lock
...
nvflinger: Use return value of Lock()
2020-07-26 09:19:24 -07:00
4524e1bd54
Merge pull request #4418 from lioncash/udp-warn
...
udp/client: Remove unused boost include
2020-07-25 21:50:37 -07:00
05def61398
hle: nvdrv: Rewrite of GPU memory management.
2020-07-26 00:49:43 -04:00
45cf48bd0a
Merge pull request #4415 from lioncash/maybe
...
virtual_buffer: Mark size parameter of FreeMemoryPages() as [[maybe_unused]]
2020-07-25 21:35:09 -07:00
b69f902b18
Merge pull request #4417 from lioncash/poll
...
gc_adapter/gc_poller: Resolve compiler warnings
2020-07-25 19:42:09 -07:00
35b96a28d7
yuzu/configure_debug: Remove duplicated checkboxes
...
Those are already found in the Filesystem tab.
They were added back to the Debug tab by mistake in the Vulkan PR.
2020-07-26 02:45:19 +02:00
7b070bbf62
nvflinger: Mark interface functions with return values as [[nodiscard]]
...
Not using the return value of these functions are undeniably the source
of a bug. This way we allow compilers to loudly make any future misuses
evident.
2020-07-25 19:42:45 -04:00
5dab23e017
nvflinger: Use return value of Lock()
...
comex reported in #4424 that we were incorrectly discarding the return
value of Lock() which is correct.
2020-07-25 19:04:53 -04:00
a2e1810287
Merge pull request #4350 from ogniK5377/hid-update-connected
...
hid: Only update keyboard & debug pad inputs if enabled
2020-07-25 11:57:24 -07:00
e3503de588
common/string_util: Remove unimplemented function prototype ( #4414 )
...
This function was relocated to log.h as a constexpr function, so this
can be removed.
2020-07-25 15:37:51 +02:00
3dcbba38bf
Fix perf regression
2020-07-25 21:46:25 +10:00
80eedff9e1
vulkan: Resolve -Wmissing-field-initializer warnings
2020-07-25 03:50:18 -04:00
1a7cf26884
udp/client: Remove unused boost include
...
Also silences a deprecation warning from boost on Clang/GCC.
2020-07-25 03:42:03 -04:00
ac7e4e2cab
gc_adapter: Resolve C++20 deprecation warning
2020-07-25 03:38:22 -04:00
04699c366b
gc_poller: Resolve -Wsign-compare warning
2020-07-25 03:37:22 -04:00
e19972dfc4
gc_poller: Resolve -Wredundant-move warning
2020-07-25 03:35:40 -04:00
2e511246fa
lz4_compression: Make use of std::span in interfaces
...
Allows compressing the data and size parameters into one.
2020-07-25 03:17:04 -04:00
c5bdccfecb
zstd_compression: Make use of std::span in interfaces
...
Allows condensing the data and size parameters into a single argument.
2020-07-25 03:11:56 -04:00
ca6ff01333
virtual_buffer: Mark size parameter of FreeMemoryPages() as [[maybe_unused]]
...
This isn't used on Windows, but is used on non-Windows operating
systems.
2020-07-25 03:04:27 -04:00
d046e9b458
Merge pull request #4380 from ogniK5377/swkbd-inline-1
...
swkbd: Return result for Calc request for inlined swkbd
2020-07-24 22:31:24 -07:00
dc2d31b1b2
Merge pull request #4393 from lioncash/unused5
...
vk_rasterizer: Remove unused variable in Clear()
2020-07-24 20:33:58 -07:00
f4eb7dceaf
Fix stream channel count when outputting to stereo
2020-07-25 13:31:43 +10:00
b924c71822
Address issues
2020-07-25 12:39:37 +10:00
8a497adf85
Queue extra mix buffer
2020-07-25 12:39:36 +10:00
d68856ab12
Disable time stretcher for time being
2020-07-25 12:39:35 +10:00
380658c21d
audio_core: Apollo Part 1, AudioRenderer refactor
2020-07-25 12:39:34 +10:00
c73701edea
Merge pull request #4377 from Morph1984/dark-themes
...
qt-themes: Add Midnight Blue qdarkstyle theme (2.8.1)
2020-07-24 19:23:45 -07:00
2ed8f3f549
Merge pull request #4334 from lat9nq/clear-per-game-settings
...
configure_per_game: Clearer per-game settings
2020-07-24 19:19:27 -07:00
d488cb843e
Merge pull request #4388 from lioncash/written
...
buffer_cache: Eliminate redundant map lookup in MarkRegionAsWritten()
2020-07-24 11:29:37 -07:00
f650cf8a9a
Merge pull request #4391 from lioncash/nrvo
...
video_core: Allow copy elision to take place where applicable
2020-07-24 06:33:09 -07:00
1d7de0a8ee
Merge pull request #4394 from lioncash/unused6
...
video_core: Remove unused variables
2020-07-23 19:54:59 -07:00
5ac91a6c7a
Merge pull request #4353 from ameerj/gc-refactor
...
gc_adapter: Refactor code
2020-07-23 18:44:39 -07:00
f99be1c923
network: add missing include for BSDs
...
src/core/network/network.cpp:112:28: error: use of undeclared identifier 'SHUT_RD'
constexpr int SD_RECEIVE = SHUT_RD;
^
src/core/network/network.cpp:113:25: error: use of undeclared identifier 'SHUT_WR'
constexpr int SD_SEND = SHUT_WR;
^
src/core/network/network.cpp:114:25: error: use of undeclared identifier 'SHUT_RDWR'
constexpr int SD_BOTH = SHUT_RDWR;
^
src/core/network/network.cpp:120:37: error: unknown type name 'in_addr'; did you mean 'in_addr_t'?
constexpr IPv4Address TranslateIPv4(in_addr addr) {
^~~~~~~
in_addr_t
/usr/include/netdb.h:66:20: note: 'in_addr_t' declared here
typedef __uint32_t in_addr_t;
^
src/core/network/network.cpp:121:27: error: member reference base type 'in_addr_t' (aka 'unsigned int') is not a structure or union
const u32 bytes = addr.s_addr;
~~~~^~~~~~~
src/core/network/network.cpp:121:15: error: variables defined in a constexpr function must be initialized
const u32 bytes = addr.s_addr;
^
src/core/network/network.cpp:126:10: error: incomplete result type 'sockaddr' in function definition
sockaddr TranslateFromSockAddrIn(SockAddrIn input) {
^
/usr/include/netdb.h:142:9: note: forward declaration of 'sockaddr'
struct sockaddr *ai_addr; /* binary address */
^
src/core/network/network.cpp:127:5: error: unknown type name 'sockaddr_in'; did you mean 'sockaddr'?
sockaddr_in result;
^~~~~~~~~~~
sockaddr
/usr/include/netdb.h:142:9: note: 'sockaddr' declared here
struct sockaddr *ai_addr; /* binary address */
^
src/core/network/network.cpp:127:17: error: variable has incomplete type 'sockaddr'
sockaddr_in result;
^
/usr/include/netdb.h:142:9: note: forward declaration of 'sockaddr'
struct sockaddr *ai_addr; /* binary address */
^
src/core/network/network.cpp:131:29: error: use of undeclared identifier 'AF_INET'
result.sin_family = AF_INET;
^
src/core/network/network.cpp:135:29: error: use of undeclared identifier 'AF_INET'
result.sin_family = AF_INET;
^
src/core/network/network.cpp:139:23: error: use of undeclared identifier 'htons'
result.sin_port = htons(input.portno);
^
src/core/network/network.cpp:143:14: error: variable has incomplete type 'sockaddr'
sockaddr addr;
^
/usr/include/netdb.h:142:9: note: forward declaration of 'sockaddr'
struct sockaddr *ai_addr; /* binary address */
^
src/core/network/network.cpp:156:1: error: unknown type name 'linger'
linger MakeLinger(bool enable, u32 linger_value) {
^
src/core/network/network.cpp:157:5: error: unknown type name 'linger'
linger value;
^
src/core/network/network.cpp:185:16: error: use of undeclared identifier 'AF_INET'
return AF_INET;
^
src/core/network/network.cpp:195:16: error: use of undeclared identifier 'SOCK_STREAM'
return SOCK_STREAM;
^
src/core/network/network.cpp:197:16: error: use of undeclared identifier 'SOCK_DGRAM'
return SOCK_DGRAM;
^
src/core/network/network.cpp:207:16: error: use of undeclared identifier 'IPPROTO_TCP'
return IPPROTO_TCP;
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
2020-07-22 22:10:15 +00:00
8abb31a19d
vi: IApplicationDisplayService:GetIndirectLayerImageRequiredMemoryInfo
...
Needed for dark souls and monster hunter
2020-07-21 23:06:18 +10:00
7278c59d70
Merge pull request #4359 from ReinUsesLisp/clamp-shared
...
renderer_{opengl,vulkan}: Clamp shared memory to host's limit
2020-07-21 04:51:05 -03:00
721e6015a8
Merge pull request #4360 from ReinUsesLisp/glasm-bar
...
gl_arb_decompiler: Execute BAR even when inside control flow
2020-07-21 04:50:55 -03:00
9ea9a60e17
Merge pull request #4361 from ReinUsesLisp/lane-id
...
decode/other: Implement S2R.LaneId
2020-07-21 04:50:45 -03:00
82b7e5c8ee
surface_params: Make use of designated initializers where applicable
...
Provides a convenient way to avoid unnecessary zero initializing.
2020-07-21 02:27:22 -04:00
bd9545a3a8
surface_params: Remove redundant assignment
...
This is a redundant assignment that can be removed.
2020-07-21 02:26:49 -04:00
c705a1db96
surface_params: Replace questionable usages of the comma operator with semicolons
...
These are bugs waiting to happen.
2020-07-21 02:26:48 -04:00
e9bfe05e04
Merge pull request #4306 from ReinUsesLisp/bsd-network
...
core/network: Add network abstraction
2020-07-21 16:05:47 +10:00
e17fb5ee97
video_core: Remove unused variables
...
Silences several compiler warnings about unused variables.
2020-07-21 00:57:25 -04:00
4b369126c4
vk_rasterizer: Remove unused variable in Clear()
...
The relevant values are already assigned further down in the lambda, so
this can be removed entirely.
2020-07-21 00:49:10 -04:00
059305a6bf
compatible_formats: Add missing header guard
...
Prevents potential inclusion issues from occurring.
2020-07-21 00:42:19 -04:00
6adc824d9d
video_core: Allow copy elision to take place where applicable
...
Removes const from some variables that are returned from functions, as
this allows the move assignment/constructors to execute for them.
2020-07-21 00:36:13 -04:00
3d13d7f48f
Merge pull request #4324 from ReinUsesLisp/formats
...
video_core: Fix, add and rename pixel formats
2020-07-21 00:13:04 -04:00
e35239b861
configure_ui: Ensure a separator follows the returned path
2020-07-20 23:19:07 -04:00
19250aadee
configure_ui: don't use an empty string
...
If the user had cancelled, it would clear the text box. That behavior was sanitized underneath, but may anyways cause inconveniences.
2020-07-20 23:11:46 -04:00
599b7c26a9
main: Don't use as many string copies
...
Co-Authored-By: LC <lioncash@users.noreply.github.com>
2020-07-20 23:03:55 -04:00
a723ed31fd
main: rewrite (save as) screenshot saving
...
This picks a default directory and file name. If on Windows and save-as screenshot saving is enabled, it asks the user, first defaulting to the default screenshot path, and with a default filename in the format `[title_id]_[year-mt-dy_hr-mn-sc-msc].png`. Otherwise, or on Linux for now, it simply saves a file in that directory with that file name.
2020-07-20 23:03:55 -04:00
71b902cf62
configuration: Setup UI to config screenshot path and saving
...
This adds two options to the General -> UI tab. The first disables picking a place to save the file. The second chooses a default directory for saving screenshots.
2020-07-20 23:03:49 -04:00
3848155c42
common: Add a screenshots directory
...
Adds a screenshots directory as a path managed by FileUtil.
2020-07-20 22:51:02 -04:00
dd4a02d15c
video_core: Remove redundant pixel format type
...
We already get the format type before converting shadow formats and during shadow formats.
2020-07-21 12:44:32 +10:00
61e4c0f83d
Merge pull request #4168 from ReinUsesLisp/global-memory
...
gl_arb_decompiler: Use NV_shader_buffer_{load,store} on assembly shaders
2020-07-20 21:54:17 -04:00
26c6c71837
buffer_cache: Eliminate redundant map lookup in MarkRegionAsWritten()
...
We can make use of emplace()'s return value to determine whether or not
we need to perform an increment.
emplace() performs no insertion if an element already exist, so this can
eliminate a find() call.
2020-07-20 17:48:00 -04:00
d942472cce
wait_tree: Include Midnight Blue dark themes
2020-07-20 01:25:25 -04:00
7e01311061
qt-themes: Add Midnight Blue qdarkstyle theme (2.8.1)
...
Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>
2020-07-20 01:25:25 -04:00
8248d76964
Address issues
2020-07-20 11:52:07 +10:00
2120740ee6
configure_graphics_advnaced: clang-format mk ii
2020-07-19 13:26:55 -04:00
23347b8869
configure_graphics_advanced: Fix oversight from rebase
2020-07-19 13:26:55 -04:00
520b4c7829
configuration_shared: Remove unused functions
...
These were only kept for compatibility with old code during testing.
2020-07-19 13:26:55 -04:00
3ef4769f31
configuration: Use forward declares and remove extraneous structs
2020-07-19 13:26:55 -04:00
335aef78c4
configuration_shared: Make CheckState strongly typed
...
Also gets rid of unnecessary explicit namespace usage.
2020-07-19 13:26:55 -04:00
55ac28769a
clang-format
2020-07-19 13:26:55 -04:00
0d462f5608
configuration_shared: Break up tracker structs to respective classes
...
One less global variable.
2020-07-19 13:26:55 -04:00
e483ed21eb
configure_system: break instead of semicolon
...
Makes the code more readable
Co-Authored-By: LC <lioncash@users.noreply.github.com>
2020-07-19 13:26:55 -04:00
d5fdbd88c8
clang-format
2020-07-19 13:26:55 -04:00
33a9218f35
configure_system: Highlight labels on startup
...
whoops
2020-07-19 13:26:55 -04:00
90a0fb1e0e
configure_graphics: Fix layout in global config
...
Fixes a regression where the global config takes up a lot of extra space.
2020-07-19 13:26:55 -04:00
c94a8a3a43
configure_per_game: Improve style consistency
...
The way the configurations are set up, it is not trivial to do this. I'll leave it as is, but the API selection, and the background color and volume slider selectors are kind of not following the style.
2020-07-19 13:26:55 -04:00
a350ae6be6
configure_system: Implement highlighted overrides
2020-07-19 13:26:55 -04:00
6316a3d8d9
configuration_shared: Add default combobox setup function
...
Not a catch-all, but helps clean up the code for when I do this a lot. Also fixes some bugs caught in configure_graphics.
2020-07-19 13:26:55 -04:00
2627241541
configuration_shared: Use an int instead of a QString
...
I noticed some of the code could be reduced to just passing the function an int, since I was doing the same thing over and over. Also clang-formats configure_graphics
2020-07-19 13:26:55 -04:00
38152ab0b9
configure_graphics_advanced: Implement highlighted overrides
2020-07-19 13:26:55 -04:00
b79a6ebf9c
configuration_shared: Switch back to background colors
...
Let's see if I make up my mind.
2020-07-19 13:26:55 -04:00
44b3183ec8
configuration_shared: Better use global text
...
Also adds trackers for graphics and advanced graphics
2020-07-19 13:26:55 -04:00
c9f93c05f7
configure_audio: fix UI margins
2020-07-19 13:26:55 -04:00
c4246b80f8
configure_graphics: Implement highlighted overrides
2020-07-19 13:26:55 -04:00
bf25d583c6
configure_audio: Implement highlighted overrides
2020-07-19 13:26:55 -04:00
da65b92f9e
configuration_shared: Require name of the widget for highlighting
...
Prevents mass-coloring of elements later on
2020-07-19 13:26:55 -04:00
5a9dc8f002
configuration_shared: Use a highlight instead of background color
...
Fixes visibility in the built-in dark theme
2020-07-19 13:26:55 -04:00
58672cc7b6
configure_general: Implement manual tristate buttons
2020-07-19 13:26:55 -04:00
e26e82d8d5
configuration_shared: Initial functions and data for manual tristate
...
Sets up initial support for implementing colored tristate functions. These functions color a QWidget blue when it's overriding a global setting, and discolor it when not. The lack of color indicates it uses the global state, replacing the Qt::CheckState::PartiallyChecked state with the global state.
2020-07-19 13:26:55 -04:00
68d6d3e173
Fix axis thresholding while polling
...
axes were very sensitive when mapping controls.
2020-07-19 11:49:26 -04:00
d7d2c27b48
swkbd: Return result for Calc request for inlined swkbd
...
Fixes random swkbd popups in monster hunter
2020-07-19 18:56:16 +10:00
51817f6e59
core/network: Add network abstraction
...
This commit adds a network abstraction designed to implement bsd:s but
at the same time work as a generic abstraction to implement any
networking code we have to use from core.
This is implemented on top of BSD sockets on Unix systems and winsock on
Windows. The code is designed around winsocks having compatibility
definitions to support both BSD and Windows sockets.
2020-07-19 04:12:40 -03:00
ad0b295125
Merge pull request #4376 from ogniK5377/dark-wait-tree
...
frontend: Improve wait tree readability for dark themes
2020-07-19 03:55:36 -03:00
db43b37e15
alignment: explicitly include <new> after 723edb4c06
...
In file included from src/core/hle/kernel/memory/page_table.cpp:5:
src/./common/alignment.h:67:68: error: no member named 'align_val_t' in namespace 'std'
return static_cast<T*>(::operator new (n * sizeof(T), std::align_val_t{Align}));
~~~~~^
src/./common/alignment.h:71:51: error: no member named 'align_val_t' in namespace 'std'
::operator delete (p, n * sizeof(T), std::align_val_t{Align});
~~~~~^
2020-07-18 23:06:16 +00:00
617eeb09e0
Address issues
2020-07-19 01:02:41 +10:00
4450a2688a
Address trivial review comments.
2020-07-18 14:09:13 +02:00
0072003a14
configure_ui: Address some review comments from the previous PR
2020-07-18 14:09:13 +02:00
347b50ad43
yuzu: Port translation support from Citra
...
Co-Authored-By: Weiyi Wang <wwylele@gmail.com>
2020-07-18 14:09:11 +02:00
db4502b7b7
frontend: Improve wait tree readability for dark themes
2020-07-18 20:22:03 +10:00
4a8cb9a706
Merge pull request #4348 from lioncash/nano
...
core_timing: Make usage of nanoseconds more consistent in the interface
2020-07-18 01:45:10 -04:00
bbeea7502c
Merge pull request #4373 from lioncash/allocator
...
alignment: Simplify AlignmentAllocator implementation
2020-07-18 01:04:17 -04:00
a8a2526128
gl_arb_decompiler: Use NV_shader_buffer_{load,store} on assembly shaders
...
NV_shader_buffer_{load,store} is a 2010 extension that allows GL applications
to use what in Vulkan is known as physical pointers, this is basically C
pointers. On GLASM these is exposed through the LOAD/STORE/ATOM
instructions.
Up until now, assembly shaders were using NV_shader_storage_buffer_object.
These work fine, but have a (probably unintended) limitation that forces
us to have the limit of a single stage for all shader stages. In contrast,
with NV_shader_buffer_{load,store} we can pass GPU addresses to the
shader through local parameters (GLASM equivalent uniform constants, or
push constants on Vulkan). Local parameters have the advantage of being
per stage, allowing us to generate code without worrying about binding
overlaps.
2020-07-18 01:59:57 -03:00
c700079e08
Merge pull request #4345 from Morph1984/fix-createfile
...
filesystem: Create subdirectories prior to creating a file
2020-07-18 00:59:26 -04:00
90cbcaa44a
Merge pull request #4273 from ogniK5377/async-shaders-prod
...
video_core: Add asynchronous shader decompilation and compilation
2020-07-18 00:48:27 -04:00
967307d3be
Fix style issues
2020-07-18 14:24:32 +10:00
821d295f24
Merge pull request #4364 from lioncash/desig5
...
vulkan: Make use of designated initializers where applicable
2020-07-18 00:12:43 -04:00
af1151b1b0
Merge pull request #4365 from lioncash/mii
...
mii/manager: Make use of designated initializers
2020-07-17 22:20:15 -04:00
0b733903f0
Merge pull request #4374 from ReinUsesLisp/fix-err
...
vk_device: Fix build error on old MSVC versions
2020-07-17 20:30:24 -04:00
47b305387a
Merge pull request #4366 from lioncash/mii-sign
...
mii/manager: Resolve sign mismatch warnings
2020-07-17 20:13:06 -04:00
4d4bbe756f
file_sys/nsp: Make SetTicketKeys actually do something
...
Previously, the method wasn't modifying any class state and therefore not having any effects when called.
Since this has been the case for a very long time now, I'm not sure if we couldn't just remove this method altogether.
2020-07-18 02:02:39 +02:00
81c8f92f2e
vk_device: Fix build error on old MSVC versions
...
Designated initializers on old MSVC versions fail to build when they
take the address of a constant.
2020-07-17 20:27:53 -03:00
5d95e62443
Merge pull request #4344 from VolcaEM/c3
...
dmnt_cheat_vm: Implement opcode 0xC3 (ReadWriteStaticRegister)
2020-07-17 17:11:52 -04:00
0f0b756775
Merge pull request #4309 from Morph1984/fix-romfs-bug
...
fs: Fix RomFS building when zero byte files are present
2020-07-17 17:01:20 -04:00
1e7bed0a45
std::size_t where appropriate, make error message more clear if can't read
2020-07-17 12:10:32 -04:00
19c6bf72db
Merge pull request #4322 from ReinUsesLisp/fix-dynstate
...
vk_state_tracker: Fix dirty flags for stencil_enable on VK_EXT_extended_dynamic_state
2020-07-17 09:50:45 -04:00
723edb4c06
alignment: Simplify AlignmentAllocator implementation
...
With C++20, much of the allocator interface has been simplified, so we
can make the same adjustments.
2020-07-17 08:30:12 -04:00
47956a3bbc
Merge pull request #4369 from lioncash/hle-macro
...
macro_hle: Remove unnecessary std::make_pair calls
2020-07-17 05:20:41 -04:00
9d3cbf6a90
Merge pull request #4340 from lioncash/remove
...
shader_cache: Make use of std::erase_if
2020-07-17 05:19:20 -04:00
4f473cda64
Drop settings namespace
2020-07-17 17:23:24 +10:00
85b591f6f0
Remove duplicate config
2020-07-17 14:26:18 +10:00
f48187449e
Use conditional var
2020-07-17 14:26:17 +10:00
2ba195aa0d
Drop max workers from 8->2 for testing
2020-07-17 14:26:15 +10:00
85d7a8f466
Rebase for per game settings
2020-07-17 14:26:14 +10:00
468bd9c1b0
async shaders
2020-07-17 14:24:57 +10:00
c783cf443e
Merge pull request #4347 from lioncash/logging
...
settings: Make use of std::string_view over std::string for logging
2020-07-17 13:25:06 +10:00
92f37a229e
Merge pull request #4371 from lioncash/cmake2
...
core/CMakeLists: Add missing physical_memory.h header file
2020-07-17 13:22:19 +10:00
adbf5ca50b
Merge pull request #4357 from lioncash/unused4
...
kernel: Remove unused variables
2020-07-17 13:18:31 +10:00
69f8b6a53e
Merge pull request #4358 from lioncash/unused5
...
kernel/thread: Remove unimplemented function prototype
2020-07-17 13:17:52 +10:00
c0650cd82c
macro_hle: Remove unnecessary static keywords
...
These functions are already in an anonymous namespace which makes the
functions internally linked.
2020-07-16 23:17:17 -04:00
0d10c863a5
Merge pull request #4367 from lioncash/inc2
...
constants: Add missing <array> include
2020-07-17 13:14:01 +10:00
9cca0c2f83
Merge pull request #4368 from lioncash/macro
...
macro: Resolve missing parameter in doxygen comment
2020-07-17 13:13:22 +10:00
3ce4edba64
Merge pull request #4370 from lioncash/simplify
...
macro_hle: Simplify shift expression in HLE_771BB18C62444DA0()
2020-07-17 13:13:05 +10:00
311f500753
core/CMakeLists: Add missing physical_memory.h header file
...
Allows this header file to show up in IDE CMake generators.
2020-07-16 22:56:31 -04:00
be6b7591d9
macro_hle: Simplify shift expression in HLE_771BB18C62444DA0()
...
Given the expression involves a 32-bit value, this simplifies down to
just: 0x3ffffff. This is likely a remnant from testing that was never
cleaned up.
Resolves a -Wshift-overflow warning.
2020-07-16 22:16:11 -04:00
cc935d997b
macro_hle: Remove unnecessary std::make_pair calls
...
The purpose of make_pair is generally to deduce the types within the
pair without explicitly specifying the types, so these usages were
generally unnecessary, particularly when the type is enforced by the
array declaration.
2020-07-16 21:59:25 -04:00
502dbfb9eb
macro: Resolve missing parameter in doxygen comment
...
Resolves a -Wdocumentation warning.
2020-07-16 21:54:42 -04:00
e07eb5b223
constants: Add missing <array> include
...
Eliminates reliance on an indirect include.
2020-07-16 21:43:20 -04:00
e54c940abf
mii/manager: Resolve sign mismatch warnings
...
Previously the loop termination condition was testing variables of
different signedness.
2020-07-16 21:07:04 -04:00
39ae2deb28
Merge pull request #4363 from lioncash/mismatch
...
vk_texture_cache: Amend mismatched access masks and indices in UploadBuffer
2020-07-16 21:54:40 -03:00
7f989378c0
mii/manager: Make use of designated initializers
...
Allows returning the structure in a more concise manner.
2020-07-16 20:45:33 -04:00
3bbf4462db
Merge pull request #4292 from bunnei/mii-rewrite
...
hle: service: mii: Rewrite service to properly support creation of random and default miis.
2020-07-16 20:05:40 -04:00
Lioncash
ReinUsesLisp
bunnei
german
Morph
David
ameerj
Ameer J
David Marcec
MerryMage
lat9nq
comex
Jan Beich
CrazyMax
Brian J. Tarricone
Billy Laws
FearlessTobi
James Rowe